Support different logging paths based on OS #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akim-ruslanov
requested review from
bcipriano,
gregdenton,
jrray,
smith1511,
larsbijl,
DiegoTavares,
IdrisMiles and
splhack
as code owners
|
Previous PR was closed due to issues with CLA. This PR expands on how to define paths for Windows as suggested by @bcipriano |
akim-ruslanov
force-pushed
the
logging-path-based-on-os
branch
from
7eed87b to
a52711f
Compare
DiegoTavares
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
Opencue should support different logging paths for Windows and Linux #1096
Summarize your change.
The logging paths now can be different based on OS. The path can be set up by creating a new env variable like this:
log.frame-log-root.[OS]where[OS]is related tostr_oson the job table. If no environment variable is set up, it will default to the path described incuebot/src/main/resources/opencue.propertiesThis change will allow OpenCue to be more adaptable to any system
The change was tested using unit tests and by running docker image.